ruanwenjun commented on issue #6431:
URL: 
https://github.com/apache/dolphinscheduler/issues/6431#issuecomment-952476309


   > > Good job, in addition to this, we may also need to check the table 
scheme is sync between mysql, postgresql, h2. I find there are a lot of issue 
is related to the scheme change, most of them are bug.
   > > One possible solution is to create three database and execute these 
three database create sql or database upgrade sql. There is a tool can help to 
create a test container in UT. https://www.testcontainers.org/
   > 
   > As ZhenXu said, this is not the case this issue target. But it also a good 
point to add unittest for sql ddl, cause we have some PR fix ddl syntax error, 
such as #6140.
   > 
   > Maybe we should add a new issue to track ddl syntax correct.
   > 
   > > Can we avoid the column lost by compare the columns in three databases?
   > 
   > If think this is a better solution but we have to parse sql ddl, and I 
think cost is a bit high, WDYT
   
   Yes, this is not the case this issue target, I just suddenly thought. Maybe 
we can open another issue latter to discuss how to ensure the consistency of 
table changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to