kezhenxu94 commented on a change in pull request #6500:
URL: https://github.com/apache/dolphinscheduler/pull/6500#discussion_r737487410
##########
File path:
dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -148,6 +148,7 @@ public void run() {
}
public static void main(String[] args) {
+ System.setProperty("spring.profiles.active", "h2");
Review comment:
There is no need to set this as we already have default property file?
##########
File path: dolphinscheduler-dao/src/main/resources/datasource-h2.properties
##########
@@ -0,0 +1,63 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# datasource configuration
+spring.datasource.driver-class-name=org.h2.Driver
+spring.datasource.url=jdbc:h2:mem:dolphinscheduler;MODE=MySQL;DB_CLOSE_DELAY=-1;DATABASE_TO_LOWER=true
+spring.datasource.username=sa
+spring.datasource.password=
+
+# connection configuration
+#spring.datasource.initialSize=5
+# min connection number
+#spring.datasource.minIdle=5
+# max connection number
+#spring.datasource.maxActive=50
+
+# max wait time for get a connection in milliseconds. if configuring maxWait,
fair locks are enabled by default and concurrency efficiency decreases.
+# If necessary, unfair locks can be used by configuring the useUnfairLock
attribute to true.
+#spring.datasource.maxWait=60000
+
+# milliseconds for check to close free connections
+#spring.datasource.timeBetweenEvictionRunsMillis=60000
+
+# the Destroy thread detects the connection interval and closes the physical
connection in milliseconds if the connection idle time is greater than or equal
to minEvictableIdleTimeMillis.
+#spring.datasource.timeBetweenConnectErrorMillis=60000
+
+# the longest time a connection remains idle without being evicted, in
milliseconds
+#spring.datasource.minEvictableIdleTimeMillis=300000
+
+#the SQL used to check whether the connection is valid requires a query
statement. If validation Query is null, testOnBorrow, testOnReturn, and
testWhileIdle will not work.
+#spring.datasource.validationQuery=SELECT 1
+
+#check whether the connection is valid for timeout, in seconds
+#spring.datasource.validationQueryTimeout=3
+
+# when applying for a connection, if it is detected that the connection is
idle longer than time Between Eviction Runs Millis,
+# validation Query is performed to check whether the connection is valid
+#spring.datasource.testWhileIdle=true
+
+#execute validation to check if the connection is valid when applying for a
connection
+#spring.datasource.testOnBorrow=true
+#execute validation to check if the connection is valid when the connection is
returned
+#spring.datasource.testOnReturn=false
+#spring.datasource.defaultAutoCommit=true
+#spring.datasource.keepAlive=true
+
+# open PSCache, specify count PSCache for every connection
+#spring.datasource.poolPreparedStatements=true
+#spring.datasource.maxPoolPreparedStatementPerConnectionSize=20
Review comment:
It's highly possible these won't be used any longer as it's `h2`
datasource, maybe remove them?
##########
File path:
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AbstractControllerTest.java
##########
@@ -53,6 +54,7 @@
*/
@RunWith(PowerMockRunner.class)
@PowerMockRunnerDelegate(SpringRunner.class)
+@ActiveProfiles(value = {"postgresql"}) // todo: This need changed to h2
Review comment:
Change to h2?
##########
File path: dolphinscheduler-api/src/main/resources/logback-api.xml
##########
@@ -55,7 +55,7 @@
<root level="INFO">
- <appender-ref ref="APILOGFILE"/>
+ <appender-ref ref="STDOUT"/>
Review comment:
Should revert this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
