kezhenxu94 commented on a change in pull request #6743:
URL: https://github.com/apache/dolphinscheduler/pull/6743#discussion_r744777423
##########
File path:
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/SpringConnectionFactory.java
##########
@@ -152,7 +152,7 @@ private void initializeH2Datasource() {
.setType(EmbeddedDatabaseType.H2)
.setScriptEncoding(Constants.UTF_8)
.setName("dolphinscheduler;MODE=MySQL;DATABASE_TO_LOWER=TRUE;DB_CLOSE_DELAY=-1")
-
.addScript(PropertyUtils.getString("spring.datasource.sql.schema",
"file:../sql/dolphinscheduler_h2.sql"))
+
.addScript(PropertyUtils.getString("spring.datasource.sql.schema",
"classpath:sql/dolphinscheduler_h2.sql"))
Review comment:
> Ok, but this is strange, it can work well on my environment, both test
and standalone are use h2.
>
> I agree with move the h2 file to classpath, this is good job.
That is wired and looks unreasonable, it should not work as you can see the
relative path is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
