kezhenxu94 commented on a change in pull request #6743:
URL: https://github.com/apache/dolphinscheduler/pull/6743#discussion_r745263961
##########
File path:
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java
##########
@@ -214,7 +214,6 @@ private void runInitDDL(String initSqlPath) {
if (StringUtils.isEmpty(rootDir)) {
throw new RuntimeException("Environment variable user.dir not
found");
}
- //String mysqlSQLFilePath = rootDir +
"/sql/create/release-1.0.0_schema/mysql/dolphinscheduler_ddl.sql";
String mysqlSQLFilePath = rootDir + initSqlPath +
"dolphinscheduler_ddl.sql";
Review comment:
> Since we move the sql file from `${projectRoot}/sql/xx` to classpath,
do we need to change the `mysqlSQLFilePath` here?
It's not a must because `rootDir` can be specified by users, but I can
change the default value to match this PR's changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
