zhongjiajie commented on a change in pull request #6733:
URL: https://github.com/apache/dolphinscheduler/pull/6733#discussion_r745274088
##########
File path: install.sh
##########
@@ -41,8 +41,8 @@ sed -i ${txt} "s@^export JAVA_HOME=.*@export
JAVA_HOME=${javaHome}@g" conf/env/d
# Change configuration in conf/datasource.properties
sed -i ${txt}
"s@^spring.datasource.driver-class-name=.*@spring.datasource.driver-class-name=${datasourceDriverClassname}@g"
conf/datasource.properties
sed -i ${txt}
"s@^spring.datasource.url=.*@spring.datasource.url=jdbc:${dbtype}://${dbhost}/${dbname}?characterEncoding=UTF-8\&allowMultiQueries=true@g"
conf/datasource.properties
-sed -i ${txt}
"s@^spring.datasource.username=.*@spring.datasource.username=${username}@g"
conf/datasource.properties
-sed -i ${txt}
"s@^spring.datasource.password=.*@spring.datasource.password=${password}@g"
conf/datasource.properties
+sed -i ${txt}
"s/^spring.datasource.username=.*/spring.datasource.username=${username}/g"
conf/datasource.properties
+sed -i ${txt}
"s/^spring.datasource.password=.*/spring.datasource.password=${password}/g"
conf/datasource.properties
Review comment:
Yes, we have to consider other character that must be escaped. maybe we
should add a escape function to do that, WDYT? @tracehh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
