zwZjut commented on a change in pull request #6784:
URL: https://github.com/apache/dolphinscheduler/pull/6784#discussion_r749150721
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
##########
@@ -288,10 +288,11 @@
putMsg(result, Status.TASK_DEFINE_NOT_EXIST, taskCode);
return result;
}
- TaskDefinitionLog taskDefinitionLog =
taskDefinitionLogMapper.queryByDefinitionCodeAndVersion(taskCode, version);
- taskDefinitionLog.setUserId(loginUser.getId());
- taskDefinitionLog.setUpdateTime(new Date());
- int switchVersion = taskDefinitionMapper.updateById(taskDefinitionLog);
+ TaskDefinitionLog taskDefinitionUpdate =
taskDefinitionLogMapper.queryByDefinitionCodeAndVersion(taskCode, version);
+ taskDefinitionUpdate.setUserId(loginUser.getId());
+ taskDefinitionUpdate.setUpdateTime(new Date());
+ taskDefinitionUpdate.setId(taskDefinition.getId());
Review comment:
update t_ds_task_definition by taskDefinitionLog will never succeed.
int switchVersion = taskDefinitionMapper.updateById(taskDefinitionLog); line
288 , TaskDefinitionServiceImpl.java id is differnet between
t_ds_task_definition and t_ds_task_definition, you may see the metadata of
picture and it's explanation above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
