zhongjiajie commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971254949


   > > Hi @lyggyhmm , to target specific issue from PR, we recommend use 
keyword `fix: #issue_id` or `close: #issue_id` or `closes: #issue_id` in your 
PR describe. I would not only connect issue to PR but also close issue 
automatically when PR is be closed.
   > 
   > > Hi @lyggyhmm , to target specific issue from PR, we recommend use 
keyword `fix: #issue_id` or `close: #issue_id` or `closes: #issue_id` in your 
PR describe. I would not only connect issue to PR but also close issue 
automatically when PR is be closed.
   > 
   > Thank you for your guidance. This is the first time I mention PR here. I 
may not do well in some places. I will continue to improve in the future.
   
   Hi @lyggyhmm you could reopen this PR, and just edited PR describe, we would 
help you finish your work.
   BTW, code look good to me, you just need to remove unnecessary 
`dolphinscheduler-dao/src/main/resources/datasource.properties`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to