zhongjiajie commented on a change in pull request #6782:
URL: https://github.com/apache/dolphinscheduler/pull/6782#discussion_r752836340



##########
File path: install.sh
##########
@@ -32,26 +32,21 @@ fi
 # 2.scp resources
 echo "2.scp resources"
 sh ${workDir}/script/scp-hosts.sh
-if [ $? -eq 0 ]
-then
+if [ $? -eq 0 ];then
        echo 'scp copy completed'
 else
        echo 'scp copy failed to exit'
        exit 1
 fi
 
-
 # 3.stop server
 echo "3.stop server"
 sh ${workDir}/script/stop-all.sh
 
-
 # 4.delete zk node
 echo "4.delete zk node"
-
 sh ${workDir}/script/remove-zk-node.sh $zkRoot
 
-
 # 5.startup
 echo "5.startup"
-sh ${workDir}/script/start-all.sh
+sh ${workDir}/script/start-all.sh

Review comment:
       Please keep file end with new line 
   ```suggestion
   sh ${workDir}/script/start-all.sh
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to