Linkaiup commented on pull request #6674:
URL: https://github.com/apache/dolphinscheduler/pull/6674#issuecomment-975171654


   > > > Before now, I thought that `diff` is show different between target 
branch and PR change. If the target file is deleted, the diff would show PR try 
to add all content to target branch
   > > 
   > > 
   > > `diff` may be a snapshot of the moment I submitted the code?That a bad 
news.Thank you for your reply !
   > 
   > Yeah, you are right, It just a snapshot in PR diff. So I think maybe you 
should close this PR @Linkaiup , you could go and search other good first issue 
in #5689
   
   OK.I submitted a new pr #6940 .Looking forward to your code review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to