lyq518 opened a new pull request #6972: URL: https://github.com/apache/dolphinscheduler/pull/6972
dolphinscheduler-remote mode have test code ["testSendAsync".](https://github.com/apache/dolphinscheduler/blob/5d264c9f208a089bc1f23be5f3077d2dab2b0f40/dolphinscheduler-remote/src/test/java/org/apache/dolphinscheduler/remote/NettyRemotingClientTest.java) Although the sendAsync method is not used in the project, I found a bug in my test. ## Purpose of the pull requesty If you make the following simple changes, you will reproduce this bug. Just add the end "Thread.sleep(5000);" in the test code "testSendAsync", you will find that the method “operationComplete()” is called twice. This is because there is no cleanup “FUTURE_TABLE” in the sendAsync method that triggers the logic of the timeout processing ["scanFutureTable()".](https://github.com/apache/dolphinscheduler/blob/5d264c9f208a089bc1f23be5f3077d2dab2b0f40/dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/NettyRemotingClient.java)  ## Brief change log Please see the code below for details ## Verify this pull request <!--*(Please pick either of the following options)*--> This pull request is code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: <!--*(example:)* - *Added dolphinscheduler-dao tests for end-to-end.* - *Added CronUtilsTest to verify the change.* - *Manually verified the change by testing locally.* --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
