Yao-MR commented on a change in pull request #7015:
URL: https://github.com/apache/dolphinscheduler/pull/7015#discussion_r758877087
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterSchedulerService.java
##########
@@ -273,7 +273,7 @@ private void scheduleProcess() throws Exception {
private List<Command> findCommands() {
int pageNumber = 0;
- int pageSize = masterConfig.getFetchCommandNum();
+ int pageSize = masterConfig.getFetchCommandNum() *
ServerNodeManager.MASTER_SIZE;
Review comment:
let have a back view to the core schedule 2.0, which main point is that :
1, parallel the schedule when we have many master, and to avoid conflict
when do delete transation among several master, so we use slot which is get
from registry of zk,
so we can make sure every master can handle the command which is belong to
it, am i wright ?
2, and also i assume that chage the single commnand to command list is that
we belive the master can handle the several command, am i wright ?
@caishunfeng maybe we shodld make a unify idea for above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
