dailidong commented on pull request #7041:
URL: https://github.com/apache/dolphinscheduler/pull/7041#issuecomment-982247765


   A hard work!
   
   I think it would be a better choice to submit the basic implementation of 
SPI, alert SPI, task SPI, and datasource SPI separately.
   
   I have a suggestion that a PR solves a problem. For example, the PR of Alert 
SPI only solves Alert and task SPI only solves Task Plugin. It is not a good 
practice to mix them together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to