zhongjiajie commented on issue #7156: URL: https://github.com/apache/dolphinscheduler/issues/7156#issuecomment-986200142
Hi @boy-xiaozhang , this issue mostly look good to me. But I still have some question here, maybe you could clarification for me. 1. Your first example here is > INSERT OVERWRITE TABLE test.aaa SELECT id FROM test.bbb; INSERT OVERWRITE TABLE test.bbb SELECT id FROM test.cccc; INSERT OVERWRITE TABLE test.dddd SELECT id FROM test.aaa left join test.fff But it seem you missing task `cccc` in the graph showed below. Did I missing some information or you missing some task graph? 2. In your second example, why we would create new workflow instead append new sql task into exists workflow? > or For the existing dag, the sql content is parsed when the user saves the task,task content is Did you mean when user create new workflow and create sql task which have auto match upstream task in our meta table, but task belongs to other workflow. Then we should link a workflow dependence between those two workflow? 3. BTW, I do not think we should pop a new dialog when user click "save" button after they finish sql task definition. > if the user can write a HiveSQL or Spark SQL task and click Save, the pop-up box prompts the dependencies that the task may use I found out we already have `upstream task` setting in our sql task definition as below. So maybe we could reuse it, add suggest upstream task base on sql parser, WDYT  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
