zhongjiajie commented on issue #7069:
URL: 
https://github.com/apache/dolphinscheduler/issues/7069#issuecomment-986201802


   Hi, @calvinjiang, thanks for pointing it, I know the attribute `env` so I 
submit PR https://github.com/apache/dolphinscheduler-website/pull/555 for our 
website.  But I do not think this is a good way to set python virtualenv. I 
mean, it could but it not the best practices.
   
   You could see my issue above, for now python virtualenv is some level as 
parent interpreter, but is should in tree shape which mean virtualenv is 
children interpreter to parent interpreter(see second example)
   
   > Cause environment is for all task attribute, but virtualenv only for 
python interpreter. for now is more look like
   >
   ```sh
   |-- parent python interpreter
   |-- parent python interpreter virtunlenv1
   |-- parent python interpreter virtunlenv2
   ```
   > All python virtualenv is visible to all type task. But I think a better 
way is virtualenv only for python task
   >
   ```sh
   |-- parent python interpreter
       |-- parent python interpreter virtunlenv1
       |-- parent python interpreter virtunlenv2
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to