lenboo commented on a change in pull request #7207:
URL: https://github.com/apache/dolphinscheduler/pull/7207#discussion_r762792050
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/StateWheelExecuteThread.java
##########
@@ -92,16 +98,18 @@ private void checkTask() {
for (TaskInstance taskInstance : this.taskInstanceCheckList.values()) {
if (TimeoutFlag.OPEN ==
taskInstance.getTaskDefine().getTimeoutFlag()) {
long timeRemain =
DateUtils.getRemainTime(taskInstance.getStartTime(),
taskInstance.getTaskDefine().getTimeout() * Constants.SEC_2_MINUTES_TIME_UNIT);
- if (0 >= timeRemain && processTimeout(taskInstance)) {
- taskInstanceCheckList.remove(taskInstance.getId());
+ if (0 >= timeRemain &&
!taskTimeoutMap.containsKey(taskInstance.getId())) {
+ putTaskTimeoutEvent(taskInstance);
+ taskTimeoutMap.put(taskInstance.getId(), 1);
Review comment:
time out map cannot be same with retry map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
