songjianet commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763575820
##########
File path:
dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
+ let type = tasksType[typeKey]
Review comment:
const type = tasksType[typeKey]
##########
File path:
dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
+ let type = tasksType[typeKey]
+ if (type) {
+ let disabled = !!type.helperLinkDisable
+ return !disabled
+ }
+ return false
+ },
+ helpUrl: function (tskType) {
Review comment:
tasktype => {}
Here `tsktype` should be replaced with `tasktype`.
##########
File path:
dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
Review comment:
typekey => {}
##########
File path:
dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
backfillRefresh: true,
// whether this is a new Task
isNewCreate: true,
- tasksTypeList: Object.keys(tasksType)
+ tasksTypeList: Object.keys(tasksType),
+ helpUrlEnable: function (typeKey) {
+ let type = tasksType[typeKey]
+ if (type) {
+ let disabled = !!type.helperLinkDisable
+ return !disabled
+ }
+ return false
Review comment:
if (!type) return false
const disabled = !! type.helperLinkDisable
return !disabled
There are three inversion operations here, can't it be simplified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
