JinyLeeChina commented on a change in pull request #6981:
URL: https://github.com/apache/dolphinscheduler/pull/6981#discussion_r763960225
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2225,6 +2236,7 @@ public String getResourceIds(TaskDefinition
taskDefinition) {
return StringUtils.join(resourceIds, ",");
}
+ @Transactional
Review comment:
1. I think there is no need to add transactions for a single operation
of the database in the method
2. If the outer layer has transaction control, the inner layer plus
transaction control will cause the outer layer's transaction to fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
