[dolphinscheduler] branch dev updated: [Fix-7375][datasource] remove excess hive jdbc principal (#7375) (#7381)

[kirs]

This is an automated email from the ASF dual-hosted git repository.

kirs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new 8c3fa47  [Fix-7375][datasource] remove excess hive jdbc principal 
(#7375) (#7381)
8c3fa47 is described below

commit 8c3fa4790346204647ad2737239e87c34669b021
Author: mask <39329477+narcasse...@users.noreply.github.com>
AuthorDate: Mon Dec 13 21:38:50 2021 +0800

    [Fix-7375][datasource] remove excess hive jdbc principal (#7375) (#7381)
    
    * [Fix-7375][datasource] remove excess hive jdbc principal (#7375)
    
    * fix ut
---
 .../apache/dolphinscheduler/api/service/DataSourceServiceTest.java   | 5 ++---
 .../datasource/api/datasource/hive/HiveDatasourceProcessor.java      | 3 ---
 .../datasource/api/datasource/spark/SparkDatasourceProcessor.java    | 3 ---
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git 
a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceServiceTest.java
 
b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceServiceTest.java
index 0a3c3c5..47ff572 100644
--- 
a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceServiceTest.java
+++ 
b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceServiceTest.java
@@ -328,9 +328,8 @@ public class DataSourceServiceTest {
         
hiveDataSourceParamDTO.setLoginUserKeytabPath("/opt/hdfs.headless.keytab");
         
hiveDataSourceParamDTO.setLoginUserKeytabUsername("test2/hdfs-myclus...@esz.com");
         connectionParam = 
DataSourceUtils.buildConnectionParams(hiveDataSourceParamDTO);
-        expected = 
"{\"user\":\"test\",\"password\":\"test\",\"address\":\"jdbc:hive2://192.168.9.1:10000\",\"database\":\"im\",\"jdbcUrl\":\"jdbc:hive2://192.168.9.1:10000/im;"
-                + 
"principal=hive/hdfs-myclus...@esz.com\",\"driverClassName\":\"org.apache.hive.jdbc.HiveDriver\",\"validationQuery\":\"select
 1\",\"principal\":\"hive/hdfs-myclus...@esz.com\","
-                + 
"\"javaSecurityKrb5Conf\":\"/opt/krb5.conf\",\"loginUserKeytabUsername\":\"test2/hdfs-myclus...@esz.com\",\"loginUserKeytabPath\":\"/opt/hdfs.headless.keytab\"}";
+
+        expected = 
"{\"user\":\"test\",\"password\":\"test\",\"address\":\"jdbc:hive2://192.168.9.1:10000\",\"database\":\"im\",\"jdbcUrl\":\"jdbc:hive2://192.168.9.1:10000/im\",\"driverClassName\":\"org.apache.hive.jdbc.HiveDriver\",\"validationQuery\":\"select
 
1\",\"principal\":\"hive/hdfs-myclus...@esz.com\",\"javaSecurityKrb5Conf\":\"/opt/krb5.conf\",\"loginUserKeytabUsername\":\"test2/hdfs-myclus...@esz.com\",\"loginUserKeytabPath\":\"/opt/hdfs.headless.keytab\"}";
         Assert.assertEquals(expected, JSONUtils.toJsonString(connectionParam));
 
     }
diff --git 
a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/hive/HiveDatasourceProcessor.java
 
b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/hive/HiveDatasourceProcessor.java
index 2f7c7af..15e2ad2 100644
--- 
a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/hive/HiveDatasourceProcessor.java
+++ 
b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/hive/HiveDatasourceProcessor.java
@@ -74,9 +74,6 @@ public class HiveDatasourceProcessor extends 
AbstractDatasourceProcessor {
         }
         address.deleteCharAt(address.length() - 1);
         String jdbcUrl = address.toString() + "/" + hiveParam.getDatabase();
-        if (CommonUtils.getKerberosStartupState()) {
-            jdbcUrl += ";principal=" + hiveParam.getPrincipal();
-        }
 
         HiveConnectionParam hiveConnectionParam = new HiveConnectionParam();
         hiveConnectionParam.setDatabase(hiveParam.getDatabase());
diff --git 
a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/spark/SparkDatasourceProcessor.java
 
b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/spark/SparkDatasourceProcessor.java
index 376399d..bb930d7 100644
--- 
a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/spark/SparkDatasourceProcessor.java
+++ 
b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/spark/SparkDatasourceProcessor.java
@@ -77,9 +77,6 @@ public class SparkDatasourceProcessor extends 
AbstractDatasourceProcessor {
         address.deleteCharAt(address.length() - 1);
 
         String jdbcUrl = address + "/" + sparkDatasourceParam.getDatabase();
-        if (CommonUtils.getKerberosStartupState()) {
-            jdbcUrl += ";principal=" + sparkDatasourceParam.getPrincipal();
-        }
 
         SparkConnectionParam sparkConnectionParam = new SparkConnectionParam();
         
sparkConnectionParam.setPassword(PasswordUtils.encodePassword(sparkDatasourceParam.getPassword()));