zhongjiajie commented on a change in pull request #557:
URL: 
https://github.com/apache/dolphinscheduler-website/pull/557#discussion_r769626151



##########
File path: docs/en-us/2.0.0/user_doc/guide/installation/pseudo-cluster.md
##########
@@ -149,6 +149,19 @@ dbname="dolphinscheduler"
 # Registration center address, the address of zookeeper service
 registryServers="localhost:2181"
 ```
+* Modify the environment variable in `dolphinscheduler_env.sh` file which on 
the 'conf/env' directory (take the relevant software installed under 
'/opt/soft' as an example)

Review comment:
       Change is good, but I think we should not put these contents in this 
file. In this folder we should only write something user have to change during 
their installation time.
   Maybe we should add other sections to keep all our configurations in the 
below place or somewhere. WDYT
   
   
![image](https://user-images.githubusercontent.com/15820530/146195240-3d694335-b672-4800-806b-9486abc30861.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to