kezhenxu94 commented on a change in pull request #7481:
URL: https://github.com/apache/dolphinscheduler/pull/7481#discussion_r771830943
##########
File path: dolphinscheduler-log-server/pom.xml
##########
@@ -51,6 +51,16 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <configuration>
+ <excludes>
+ <exclude>*.yaml</exclude>
+ <exclude>*.xml</exclude>
+ </excludes>
+ </configuration>
+ </plugin>
Review comment:
The root cause is the Docker build is cached, I missed this in the first
PR, can you please add `<argument>--no-cache</argument>` next to
https://github.com/apache/dolphinscheduler/blob/b350dc70c9cafa7d1a05a3329105c96417384f2c/pom.xml#L966
and
https://github.com/apache/dolphinscheduler/blob/b350dc70c9cafa7d1a05a3329105c96417384f2c/pom.xml#L942
Adding `maven-jar-plugin` may work now but may not work in the future
because it doesn't fix the root cause in fact
##########
File path: dolphinscheduler-log-server/pom.xml
##########
@@ -51,6 +51,16 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <configuration>
+ <excludes>
+ <exclude>*.yaml</exclude>
+ <exclude>*.xml</exclude>
+ </excludes>
+ </configuration>
+ </plugin>
Review comment:
The root cause is the Docker build is cached, I missed this in the first
PR, can you please add `<argument>--no-cache</argument>` to the next line of
https://github.com/apache/dolphinscheduler/blob/b350dc70c9cafa7d1a05a3329105c96417384f2c/pom.xml#L966
and
https://github.com/apache/dolphinscheduler/blob/b350dc70c9cafa7d1a05a3329105c96417384f2c/pom.xml#L942
Adding `maven-jar-plugin` may work now but may not work in the future
because it doesn't fix the root cause in fact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
