zhongjiajie commented on a change in pull request #610: URL: https://github.com/apache/dolphinscheduler-website/pull/610#discussion_r775322608
########## File path: docs/en-us/dev/user_doc/architecture/design.md ########## @@ -187,22 +187,31 @@ Among them, the Master monitors the directories of other Masters and Workers. If -- Master fault tolerance flowchart： +- Master fault tolerance： - <p align="center"> - <img src="https://analysys.github.io/easyscheduler_docs_cn/images/fault-tolerant_master.png"; alt="Master fault tolerance flowchart" width="40%" /> +<p align="center"> + <img src="/img/failover-master.jpg" alt="failover-master" width="50%" /> </p> Review comment: I prefer to use markdown syntax instead of HTML syntax. eg. using `` instead of HTML `p` span ########## File path: docs/en-us/dev/user_doc/architecture/design.md ########## @@ -187,22 +187,31 @@ Among them, the Master monitors the directories of other Masters and Workers. If -- Master fault tolerance flowchart： +- Master fault tolerance： - <p align="center"> - <img src="https://analysys.github.io/easyscheduler_docs_cn/images/fault-tolerant_master.png"; alt="Master fault tolerance flowchart" width="40%" /> +<p align="center"> + <img src="/img/failover-master.jpg" alt="failover-master" width="50%" /> </p> -After the fault tolerance of ZooKeeper Master is completed, it is re-scheduled by the Scheduler thread in DolphinScheduler, traverses the DAG to find the "running" and "submit successful" tasks, monitors the status of its task instances for the "running" tasks, and "commits successful" tasks It is necessary to determine whether the task queue already exists. If it exists, the status of the task instance is also monitored. If it does not exist, resubmit the task instance. +Fault tolerance range: From the perspective of host, the fault tolerance range of Master includes: own host + node host that does not exist in the registry, and the entire process of fault tolerance will be locked; +Fault-tolerant content: Master's fault-tolerant content includes: fault-tolerant process instances and task instances. Before fault-tolerant, it compares the start time of the instance with the server start-up time, and skips fault-tolerance if after the server start time; -- Worker fault tolerance flowchart： +Fault-tolerant post-processing: After the fault tolerance of ZooKeeper Master is completed, it is re-scheduled by the Scheduler thread in DolphinScheduler, traverses the DAG to find the "running" and "submit successful" tasks, monitors the status of its task instances for the "running" tasks, and "commits successful" tasks It is necessary to determine whether the task queue already exists. If it exists, the status of the task instance is also monitored. If it does not exist, resubmit the task instance. - <p align="center"> - <img src="https://analysys.github.io/easyscheduler_docs_cn/images/fault-tolerant_worker.png"; alt="Worker fault tolerance flow chart" width="40%" /> + + Review comment: Remove useless blank lines ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://analysys.github.io/easyscheduler_docs_cn/images/fault-tolerant_master.png"](https://analysys.github.io/easyscheduler_docs_cn/images/fault-tolerant_master.png"){kind=link}
![https://analysys.github.io/easyscheduler_docs_cn/images/fault-tolerant_worker.png"](https://analysys.github.io/easyscheduler_docs_cn/images/fault-tolerant_worker.png"){kind=link}