zhuangchong commented on a change in pull request #7798:
URL: https://github.com/apache/dolphinscheduler/pull/7798#discussion_r778660462
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HttpUtils.java
##########
@@ -154,10 +154,10 @@ public static String getResponseContentString(HttpGet
httpget, CloseableHttpClie
logger.warn("http entity is null");
}
} else {
- logger.error("http get:{} response status code is not 200!",
response.getStatusLine().getStatusCode());
+ logger.error("http get: {} response status code is not 200!",
response.getStatusLine().getStatusCode());
}
- } catch (IOException ioe) {
- logger.error(ioe.getMessage(), ioe);
+ } catch (NullPointerException | IOException exception) {
+ logger.error(exception.getMessage(), exception);
Review comment:
I would recommend to verify the parameters before the method is
processed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
