jxeditor commented on a change in pull request #7883:
URL: https://github.com/apache/dolphinscheduler/pull/7883#discussion_r780647830
##########
File path:
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/oracle/OracleDataSourceProcessor.java
##########
@@ -65,14 +65,16 @@ public BaseDataSourceParamDTO
createDatasourceParamDTO(String connectionJson) {
public BaseConnectionParam createConnectionParams(BaseDataSourceParamDTO
datasourceParam) {
OracleDataSourceParamDTO oracleParam = (OracleDataSourceParamDTO)
datasourceParam;
String address;
+ String jdbcUrl;
if (DbConnectType.ORACLE_SID.equals(oracleParam.getConnectType())) {
address = String.format("%s%s:%s",
Constants.JDBC_ORACLE_SID, oracleParam.getHost(),
oracleParam.getPort());
+ jdbcUrl = address + "/" + oracleParam.getDatabase();
Review comment:
yes,The previous code only supported servicename
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
