tangchunbo commented on pull request #7915: URL: https://github.com/apache/dolphinscheduler/pull/7915#issuecomment-1013659496
> LGTM. > > But I prefer to combine selectById with selectByIds, then we can just keep one method. So you can remove selectById, if you want. do you mean this two methods ? i checked the useage by the first method `processService#findTaskInstanceById` and it has been uesed many situations. Besides if the first method call the second method to fullfill it's function, i think i will be complicated. what do you think, big old (大佬 LOL) @ruanwenjun  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
