hongshuboy opened a new issue #8067:
URL: https://github.com/apache/dolphinscheduler/issues/8067


   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   **Describe the question:** 
   
   `org.apache.dolphinscheduler.server.log.LoggerRequestProcessor#process`
   
   on line 72, it  has Dangling Javadoc comment and misspelling the word request
   ```java
   /**
    * reuqest task log command type
    */
   ```
   Replace with the following
   ```java
   //request task log command type
   ```
   on line 97, string concatenation as argument to 'StringBuilder.append()' call
   ```java
   for (String line : lines) {
       builder.append(line + "\r\n");
   }
   ```
   Replace with the following
   ```java
   for (String line : lines) {
       builder.append(line).append("\r\n");
   }
   ```
   on line 109, type status can be primitive
   ```java
   Boolean status = true;
   ```
   Replace with the following
   ```java
   boolean status = true;
   ```
   
   
`org.apache.dolphinscheduler.server.log.LoggerRequestProcessor#getFileContentBytes`
   
   on line 131, misspelling the word download, and `@throws Exception` is 
redundant
   ```java
   /**
    * get files content bytes,for down load file
    *
    * @param filePath file path
    * @return byte array of file
    * @throws Exception exception
    */
   ```
   Replace with the following
   ```java
   /**
    * get files content bytes for download file
    *
    * @param filePath file path
    * @return byte array of file
    */
   ```
   
   ### What you expected to happen
   
   Obvious code exception
   
   ### How to reproduce
   
   In the latest dev branch
   module: dolphinscheduler-log-server
   class: org.apache.dolphinscheduler.server.log.LoggerRequestProcessor
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to