krystalics opened a new issue #8264:
URL: https://github.com/apache/dolphinscheduler/issues/8264


   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   env :
   macos monterey 12.0.1
   java version 1.8.0_241
   
   ---
   in the  [Feature][remote] RPC design #4549 , new module has been add to 
remote which names rpc. In 
org.apache.dolphinscheduler.rpc.client.ConsumerInterceptor::cacheServiceConfig
   
   ```java
   if (!rpc.serviceCallback().isInstance(AbstractRpcCallBack.class)) {
         consumerConfig.setCallBack(true);
   }
   ```
   In my opinion this judgement wanna find the rpc.serviceCallback()'s class 
which is extend to AbstractRpcCallBack.class but not AbstractRpcCallBack.class 
itself. For example the test case --> 
org.apache.dolphinscheduler.rpc.UserCallback extends AbstractRpcCallBack.
   
   but class.isInstance() is used in a wrong way. it make the callBackIsFalse 
method callback,but in the origin code it does not set the callback service
   ```java
   public interface IUserService {
   
       @Rpc(async = true, serviceCallback = UserCallback.class)
       Boolean say(String s);
   
       Integer hi(int num);
   
       //not set the call back service
       @Rpc(async = true)
       Boolean callBackIsFalse(String s);
   }
   ```
   
![image](https://user-images.githubusercontent.com/22393849/151664043-5a8d921e-cf2f-48f4-a5a6-57d136bb4ef1.png)
   
   
   
   ### What you expected to happen
   
   the right behavior is the method callBackIsFalse() do not trigger the 
callback!
   
   the right judgement condition is :
   ```java
   if (!AbstractRpcCallBack.class.equals(rpc.serviceCallback()) && 
AbstractRpcCallBack.class.isAssignableFrom(rpc.serviceCallback())) {
         consumerConfig.setCallBack(true);
   }
   ```
   
   ### How to reproduce
   
   just run the org.apache.dolphinscheduler.rpc.RpcTest.sendTest(). it can 
reproduce
   
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to