caishunfeng commented on a change in pull request #8490:
URL: https://github.com/apache/dolphinscheduler/pull/8490#discussion_r812513714
##########
File path:
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/WorkerServer.java
##########
@@ -197,6 +202,8 @@ public void close(String cause) {
logger.warn("thread sleep exception", e);
}
+ this.killAllRunningTasks();
Review comment:
After `Stopper.stop()` , the stop signal is true. Although worker can
receive a new request, but it will not submit `taskExecuteThread`.
```
while (Stopper.isRunning()) {
try {
taskExecuteThread = workerExecuteQueue.take();
workerExecService.submit(taskExecuteThread);
} catch (Exception e) {
logger.error("An unexpected interrupt is happened, "
+ "the exception will be ignored and this thread will
continue to run", e);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
