zhongjiajie commented on a change in pull request #704:
URL:
https://github.com/apache/dolphinscheduler-website/pull/704#discussion_r815904299
##########
File path: community/en-us/development/submit-code.md
##########
@@ -38,11 +38,19 @@ git checkout -b dev-1.0 upstream/dev-1.0
git push --set-upstream origin dev-1.0
```
-* After modifying the code locally, submit it to your own repository:
+* Create new branch
+```
+git checkout -b xxx origin/dev
Review comment:
Why do we need this? I think we already have `checkout -b` command in
line 37, which is `git checkout -b dev-1.0 upstream/dev-1.0`
##########
File path: community/en-us/development/submit-code.md
##########
@@ -38,11 +38,19 @@ git checkout -b dev-1.0 upstream/dev-1.0
git push --set-upstream origin dev-1.0
```
-* After modifying the code locally, submit it to your own repository:
+* Create new branch
+```
+git checkout -b xxx origin/dev
+```
+
+Make sure that the branch `xxx` is building successfully on the latest code of
the official dev branch
+
+
+* After modifying the code locally in the new branch, submit it to your own
repository:
`git commit -m 'commit content'`
-`git push`
+`git push origin xxx`
Review comment:
```suggestion
`git push origin xxx --set-upstream` is better, WDYT?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
