EricGao888 commented on issue #9321: URL: https://github.com/apache/dolphinscheduler/issues/9321#issuecomment-1091368152
> Currently, we check weather exists not need types of img base on variable > > https://github.com/apache/dolphinscheduler/blob/9f84dbbda00956d5bf198ce7eb4c47f2ea335173/docs/img_utils.py#L35-L38 > > . But we already can find all imgs file and types base on the pattern in > https://github.com/apache/dolphinscheduler/blob/9f84dbbda00956d5bf198ce7eb4c47f2ea335173/docs/img_utils.py#L41-L43 > > from our docs directory. > So when the img not used in the docs directory, and also have some type not in the docs directory, we should remove them. But you could also find other way to do that as your wish @zhongjiajie In summary, we need to automatically remove two types of images: 1. images with the unexpected types 2. images not referenced in the docs directory However for the first point, if there are images of unexpected types, assertion will fail right away. Therefore, we only need to remove `images not referenced in the docs directory`. Please correct me if I get it wrong. https://github.com/apache/dolphinscheduler/blob/9f84dbbda00956d5bf198ce7eb4c47f2ea335173/docs/img_utils.py#L128-L135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
