zhongjiajie commented on code in PR #9327: URL: https://github.com/apache/dolphinscheduler/pull/9327#discussion_r845690966
########## dolphinscheduler-common/src/main/resources/common.properties: ########## @@ -91,3 +91,5 @@ development.state=false # rpc port alert.rpc.port=50052 +# Url endpoint for zeppelin RESTful API +zeppelin.rest.url="http://localhost:8080"; Review Comment: > @zhuangchong May I ask where can I add parameter for zeppelin plugin instead of public parameter? Is there anything like task-plugin level properties file? Why we should have separate configurations for a single task? I think we should get all config in one single config file. It is easy to maintain and also easy for uses. For ex, when we change our task structure(like add provider) we have to move our code from one side to another, if config file alone with task code, maybe they should change the position too. And this will make user confuse for the position change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
