zhongjiajie commented on PR #9673: URL: https://github.com/apache/dolphinscheduler/pull/9673#issuecomment-1107283101
BTW, i think your point on issues is great > Sql type will be identified by the regex. I think it should be specified by a parameter. We need to implement the override of user-specified `sql type` parameters, because the user may have specific user case. and we should add param in https://github.com/apache/dolphinscheduler/blob/0c7aa4e2c5af05a1df099e1ba29cef876446f79e/dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/sql.py#L63 ```py self.sql_type: Optional[str] = "select", ``` and add the overwrite logic in function if self.sql_type is sprcific https://github.com/apache/dolphinscheduler/blob/0c7aa4e2c5af05a1df099e1ba29cef876446f79e/dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/sql.py#L77-L87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
