ruanwenjun commented on code in PR #9718:
URL: https://github.com/apache/dolphinscheduler/pull/9718#discussion_r857118199
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/utils/DagHelper.java:
##########
@@ -565,20 +554,40 @@ public static boolean haveConditionsAfterNode(String
parentNodeCode, List<TaskNo
return false;
}
+
/**
* is there have blocking node after the parent node
*/
public static boolean haveBlockingAfterNode(String parentNodeCode,
DAG<String,TaskNode,TaskNodeRelation> dag) {
+ return haveSubAfterNode(parentNodeCode, dag, true,
TaskConstants.TASK_TYPE_BLOCKING);
+ }
+
+ /**
+ * is there have all node after the parent node
+ */
+ public static boolean haveAllNodeAfterNode(String parentNodeCode,
Review Comment:
@WangJPLeo I mean that it better to rename this method name to
`haveAnyNodeAfterNode`, since I find you just want to check if there exist any
node after the parentNodeCode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
