SbloodyS commented on issue #9675:
URL:
https://github.com/apache/dolphinscheduler/issues/9675#issuecomment-1107981919
> After looking into other modules' start scripts, it seems even config
`bin/env/dolphinscheduler_env.sh` will not take effect globally. In each
module's start script except that of `worker-server`, it sources the
`dolphinscheduler_env.sh` in its own `bin` folder instead of the global
`bin/env/dolphinscheduler_env.sh`. Also each module's start script uses its own
lib, which means if users use mysql driver, they need to add mysql-connector
jar into every module's lib folder. Therefore, there are two problems:
>
> * Why `worker-sever` uses the global `bin/env/dolphinscheduler_env.sh` but
others don't?
> * Is there any way more convenient for users to config
`dolphinscheduler_env.sh` or add extra jar, e.g. mysql-connector jar, into lib
folder?
For ```dolphinscheduler_env.sh```. I think it can be solved in a unified way
for the following scenarios.
First of all by adding a variable like ```--envpath``` in each modules
```start.sh```.
1. For those users who want to use in ```docker``` deployment. Setting the
default value of ```--envpath``` to ```source``` each module's own
```dolphinscheduler_env.sh``` when executing ```bash bin/start.sh``` in docker
container's starting.
2. For those users who want to use in ```non docker and cluster```
deployment. Then specify ```--envpath source
${DOLPHINSCHEDULER_HOME}/bin/env/dolphinscheduler_env.sh``` in
```start-all.sh/stop-all.sh/scp-hosts.sh/dolphinscheduler-daemon.sh```.
3. For thos users who want to use in ```user defined``` deployment. Then
users can chose using the way of setting
```${DOLPHINSCHEDULER_HOME}/bin/env/dolphinscheduler_env.sh``` or By using
```bin/start.sh -- envpath``` to customize its own path.
If we do this. we should also modify the docs. WDYT? @EricGao888
@caishunfeng @zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]