devosend commented on code in PR #9735:
URL: https://github.com/apache/dolphinscheduler/pull/9735#discussion_r857574623
##########
dolphinscheduler-ui-next/src/common/common.ts:
##########
@@ -33,9 +33,9 @@ import {
IssuesCloseOutlined,
SendOutlined
} from '@vicons/antd'
-import { parseISO } from 'date-fns'
+import {format, parseISO} from 'date-fns'
Review Comment:
it should be format
##########
dolphinscheduler-ui-next/src/common/common.ts:
##########
@@ -33,9 +33,9 @@ import {
IssuesCloseOutlined,
SendOutlined
} from '@vicons/antd'
-import { parseISO } from 'date-fns'
+import {format, parseISO} from 'date-fns'
import _ from 'lodash'
-import { ITaskStateConfig } from './types'
+import {ITaskStateConfig} from './types'
Review Comment:
it should be format as `import { ITaskStateConfig } from './types'`
##########
dolphinscheduler-ui-next/src/views/resource/task-group/queue/use-table.ts:
##########
@@ -149,14 +148,8 @@ export function useTable(
}
item.taskGroupName = taskGroupName
- item.createTime = format(
- parseTime(item.createTime),
- 'yyyy-MM-dd HH:mm:ss'
- )
- item.updateTime = format(
- parseTime(item.updateTime),
- 'yyyy-MM-dd HH:mm:ss'
- )
+ item.createTime = simpleDateFormat(item.createTime)
Review Comment:
`createTime` and `updateTime` look like not be format. it will be format in
table render.
##########
dolphinscheduler-ui-next/src/views/resource/task-group/option/use-table.ts:
##########
@@ -139,14 +138,8 @@ export function useTable(
}
item.projectName = projectName
- item.createTime = format(
- parseTime(item.createTime),
- 'yyyy-MM-dd HH:mm:ss'
- )
- item.updateTime = format(
- parseTime(item.updateTime),
- 'yyyy-MM-dd HH:mm:ss'
- )
+ item.createTime = simpleDateFormat(item.createTime)
Review Comment:
`createTime` and `updateTime` look like not be format. it will be format in
table render.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
