exmy commented on code in PR #9671:
URL: https://github.com/apache/dolphinscheduler/pull/9671#discussion_r859469470
##########
docs/docs/en/guide/parameter/context.md:
##########
@@ -55,7 +55,15 @@ There is only the "id" value. Although the user-defined SQL
query both "id" and
### SHELL
`prop` is user-specified and the direction is `OUT`. The output is defined as
an export parameter only when the direction is `OUT`. Choose data structures
for data type according to the scenario, and leave the value part blank.
-The user needs to pass the parameter when creating the shell script, the
output statement format is `${setValue(key=value)}`, the key is the `prop` of
the corresponding parameter, and value is the value of the parameter.
+
+The user needs to pass the parameter when creating the shell script, the
output statement format is `${setValue(key=value)}` or
`#{setValue(key=value)}`, the key is the `prop` of the corresponding parameter,
and value is the value of the parameter.
Review Comment:
Maybe we can change it to this:
"If the user wants to pass parameters, you need to output statements in the
form of `${setValue(key=value)}` or `#{setValue(key=value)}` when defining the
shell script, where the key is the `prop` of the corresponding parameter, and
value is the value of the parameter.
如果用户想要传递参数，那么在定义 shell 脚本时，需要输出格式为 `${setValue(key=value)}` 或者
`#{setValue(key=value)}` 的语句，其中 key 为对应参数的 prop，value 为该参数的值。"
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
