zhongjiajie commented on code in PR #9773:
URL: https://github.com/apache/dolphinscheduler/pull/9773#discussion_r859673423
##########
dolphinscheduler-python/pydolphinscheduler/docs/source/config.rst:
##########
@@ -108,6 +108,8 @@ All environment variables as below, and you could modify
their value via `Bash <
| | ``PYDS_WORKFLOW_WORKER_GROUP`` | Default workflow
worker group, will use its value when workflow does not specify the attribute
``worker_group``. |
+
+------------------------------------+------------------------------------------------------------------------------------------------------------------+
| | ``PYDS_WORKFLOW_TIME_ZONE`` | Default workflow
worker group, will use its value when workflow does not specify the attribute
``timezone``. |
++
+------------------------------------+------------------------------------------------------------------------------------------------------------------+
+| | ``PYDS_WORKFLOW_WARNING_TYPE`` | Default workflow
warning type, will use its value when workflow does not specify the attribute
``warning_type``. |
Review Comment:
Good job to add config to docs 👍 I almost forget about it
##########
dolphinscheduler-python/pydolphinscheduler/tests/core/test_configuration.py:
##########
@@ -263,4 +266,6 @@ def test_get_configuration_env(config_name: str, src: Any,
dest: Any):
assert getattr(configuration, config_name) == dest
os.environ.pop(env_name, None)
Review Comment:
🎉 Good test cases add 👍
##########
dolphinscheduler-python/pydolphinscheduler/tests/core/test_configuration.py:
##########
@@ -263,4 +266,6 @@ def test_get_configuration_env(config_name: str, src: Any,
dest: Any):
assert getattr(configuration, config_name) == dest
os.environ.pop(env_name, None)
Review Comment:
```suggestion
# pop and reload configuration to test whether this config equal to
`src` value
os.environ.pop(env_name, None)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
