[GitHub] [dolphinscheduler] czeming commented on issue #9449: [Feature][Doc] Improve the description of code inspection specification.

Fri, 29 Apr 2022 03:03:21 -0700 


czeming commented on issue #9449:
URL: 
https://github.com/apache/dolphinscheduler/issues/9449#issuecomment-1113133381

   > I can see the configuration takes effect after importing the checkStyle.xml
   > 
   > <img alt="image" width="944" 
src="https://user-images.githubusercontent.com/15965696/165442137-5dece4b1-6ec4-4695-9db3-13712211d23b.png";>
   
   It's the current configuration.
   ```
   <property name="staticGroups" 
value="org.apache.dolphinscheduler,org.apache,java,javax,org,com"/>
   ...
   <property name="option" value="top"/>
   ```
   
   You can see this code.
   
`https://github.com/jshiell/checkstyle-idea/blob/ac7a6b16c065848d0de9d1985e0f97fda38634c8/src/main/java/org/infernus/idea/checkstyle/importer/modules/ImportOrderImporter.java`
   ```
           switch (staticImportPosition) {
               case TOP:
                   // remove other instances of 
PackageEntry.ALL_OTHER_STATIC_IMPORTS_ENTRY from the table
                   // iterate from the end so we can remove elements without 
having to modify the index afterwards
                   for (int x = settings.IMPORT_LAYOUT_TABLE.getEntryCount() - 
1; x >= 0; x--) {
                       if (settings.IMPORT_LAYOUT_TABLE.getEntryAt(x) == 
PackageEntry.ALL_OTHER_STATIC_IMPORTS_ENTRY) {
                           settings.IMPORT_LAYOUT_TABLE.removeEntryAt(x);
                       }
                   }
                   
settings.IMPORT_LAYOUT_TABLE.insertEntryAt(PackageEntry.ALL_OTHER_STATIC_IMPORTS_ENTRY,
 0);
                   break;
               case BOTTOM:
   ```
   
   The question is`IntelliJ` only imports `static all other import`.
   
   I've been a little busy recently, so I didn't update latest discussion  in 
the issue content.
   what I expect support static import sort. (Please ignore the content of 
`import with '*'`, I used the screenshot from the past.)
   ![](https://s2.loli.net/2022/04/12/bwsKRJxYTAlEHIS.png)
   
   Maybe I need to make an issue for `checkstyle-idea`.
   
   @zhongjiajie @kezhenxu94 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to