zhongjiajie commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r872488495
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -56,7 +56,15 @@ $ tar -zxf
apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src.tar.gz
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src/deploy/docker
# For Windows users
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src\deploy\docker
Review Comment:
```suggestion
# For Windows users, you should run command `cd
apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src\deploy\docker`
```
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
+ ports:
+ - "5432:5432"
+ profiles: ["all", "schema-init"]
Review Comment:
Thanks, I learn the new statement `profile` of `docker-compose`
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -56,7 +56,15 @@ $ tar -zxf
apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src.tar.gz
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src/deploy/docker
# For Windows users
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src\deploy\docker
-$ docker-compose up -d
+
+# Initialize the database, use profile schema-init
+$ docker-compose --profile schema-init up -d
+
+# start api-server
+$ docker-compose up dolphinscheduler-postgresql dolphinscheduler-zookeeper
dolphinscheduler-api
+
Review Comment:
I think we should directly remove this command, because when we run
`--profile all` will create and start all server we need, correct me if I wrong
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -111,6 +123,7 @@ $ docker run -d --name dolphinscheduler-alert-server \
-e SPRING_DATASOURCE_USERNAME="<USER>" \
-e SPRING_DATASOURCE_PASSWORD="<PASSWORD>" \
-e REGISTRY_ZOOKEEPER_CONNECT_STRING="localhost:2181" \
+ --net host \
Review Comment:
Good catch!
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
+ ports:
+ - "5432:5432"
+ profiles: ["all", "schema-init"]
Review Comment:
BTW, we should change the document and note users should use
`docker-comopse` after version `1.28.0` according
https://docs.docker.com/compose/release-notes/#1280. And I find out all
examples in https://docs.docker.com/compose/profiles/ using `version: "3.9"`,
did you test 3.8 locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
