SbloodyS commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873277977
##########
deploy/kubernetes/dolphinscheduler/templates/job-dolphinscheduler-schema-initializer.yaml:
##########
@@ -38,10 +38,12 @@ spec:
image: {{ include "dolphinscheduler.image.fullname.tools" . }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- - bin/create-schema.sh
+ - tools/bin/upgrade-schema.sh
Review Comment:
I think we should add a variable to judge whether it is docker in
```upgrade-schema.sh```. If it is docker, we will not execute ```source
dolphinscheduler-env.sh```. Otherwise, the no such file error will be printed
to terminal which will misleading the user's judgment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
