huangchenguang123 commented on issue #10049: URL: https://github.com/apache/dolphinscheduler/issues/10049#issuecomment-1129119855
> > > I will fix it. > > > > > > Conditions should use previousNodes result, and now only use dependency result? I find add Custom Parameters can make it trigger fail Node....May be #10077 should use previousNodes and/or Custom Parameters? This is my doubt, don't mind if I'm wrong. > > Yes. In this PR, I change the detection logic to use previousNodes to check condition instead of use dependency result. > > However, I don't think the success or failure of task nodes should be related to user-defined parameters. The Condition's Custom Parameters is different from other, it's has and/or relation with pre node in ui(it's also only has success and failure), and when i run the task, these Custom Parameters will be used in dependencyList, this is why i think they should be calculate together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
