SbloodyS commented on code in PR #10175: URL: https://github.com/apache/dolphinscheduler/pull/10175#discussion_r878966864
########## docs/docs/en/guide/task/mlflow.md: ########## @@ -114,6 +110,24 @@ First, introduce some general parameters of DolphinScheduler and [flaml](https://github.com/microsoft/FLAML) +#### Custom projects + + + +**Task Parameter** + +- **mlflow server tracking uri** ：MLflow server uri, default http://localhost:5000. +- **experiment name** ：The experiment in which the task is running, if none, is created. Review Comment: Will experience name be created automatically? If so, i think it's better to use ```The experiment in which the task is running. If it is blank, it will be created automatically.``` So as chinese doc. ########## dolphinscheduler-task-plugin/dolphinscheduler-task-mlflow/src/test/java/org/apache/dolphinler/plugin/task/mlflow/MlflowTaskTest.java: ########## @@ -90,6 +90,13 @@ public void testInitAutoMLTask() throws Exception { String command = mlflowTask.buildCommand(); } + @Test + public void testInitCustomProjectTask() throws Exception { + MlflowTask mlflowTask = initTask(createCustomProjectParameters()); + String command = mlflowTask.buildCommand(); + mlflowTask.handle(); Review Comment: Assert should be used in some of tests to verify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
