ruanwenjun commented on code in PR #9919:
URL: https://github.com/apache/dolphinscheduler/pull/9919#discussion_r878977760
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/LowerWeightRoundRobin.java:
##########
@@ -45,7 +51,21 @@ public HostWeight doSelect(Collection<HostWeight> sources) {
}
lowerNode.setCurrentWeight(lowerNode.getCurrentWeight() + totalWeight);
return lowerNode;
+ }
+ private List<HostWeight> canAssignTaskHost(Collection<HostWeight> sources)
{
Review Comment:
```suggestion
private List<HostWeight>
findMinimumWaitingTaskHost(Collection<HostWeight> sources) {
```
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/HostWeight.java:
##########
@@ -37,10 +37,13 @@ public class HostWeight {
private double currentWeight;
- public HostWeight(HostWorker hostWorker, double cpu, double memory, double
loadAverage, long startTime) {
+ private final int waitingTaskCount;
+
+ public HostWeight(HostWorker hostWorker, double cpu, double memory, double
loadAverage, int waitingTaskCount, long startTime) {
Review Comment:
Does the `startTime` be used? If this is not used, we can remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
