Amy0104 commented on code in PR #10202:
URL: https://github.com/apache/dolphinscheduler/pull/10202#discussion_r879217110
##########
dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-rules.ts:
##########
@@ -67,9 +67,10 @@ export function useRules(
if (ruleLoading.value) return
ruleLoading.value = true
const result = await getRuleFormCreateJson(ruleId)
- const items = JSON.parse(result).map((item: IResponseJsonItem) =>
- formatResponseJson(item)
- )
+ const items = JSON.parse(result).map((item: IResponseJsonItem) => {
+ item.props.placeholder = t('project.node.' +
item.props.placeholder.split(' ').join('_').split(',').join('').toLowerCase())
+ return formatResponseJson(item)
+ })
Review Comment:
It's better to handle the placeholder format in the formatResponseJson
function as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
