zhongjiajie commented on code in PR #10221: URL: https://github.com/apache/dolphinscheduler/pull/10221#discussion_r880165058
########## docs/docs/en/guide/installation/kubernetes.md: ########## @@ -186,24 +186,31 @@ kubectl scale --replicas=6 sts dolphinscheduler-worker -n test # with test names > Because of the commercial license, we cannot directly use the driver of > MySQL. > -> If you want to use MySQL, you can build a new image based on the `apache/dolphinscheduler` image follow the following instructions: +> If you want to use MySQL, you can build a new image based on the `apache/dolphinscheduler-<service>` image follow the following instructions: +> +> Since version 3.0.0, dolphinscheduler has been microserviced and the change of metadata storage requires replacing all services with MySQL driver. +> +> dolphinscheduler-tools dolphinscheduler-master dolphinscheduler-worker dolphinscheduler-api dolphinscheduler-alert-server Review Comment: ```suggestion > Since version 3.0.0, dolphinscheduler has been microserviced and the change of metadata storage requires replacing all services with MySQL driver, which including dolphinscheduler-tools, dolphinscheduler-master, dolphinscheduler-worker, dolphinscheduler-api, dolphinscheduler-alert-server ``` ########## docs/docs/en/guide/installation/kubernetes.md: ########## @@ -229,24 +235,29 @@ externalDatabase: > Because of the commercial license, we cannot directly use the driver of > MySQL. > -> If you want to add MySQL datasource, you can build a new image based on the `apache/dolphinscheduler` image follow the following instructions: +> If you want to add MySQL datasource, you can build a new image based on the `apache/dolphinscheduler-<service>` image follow the following instructions: +> +> You needs to change the two images of dolphinscheduler-worker dolphinscheduler-api service. 1. Download the MySQL driver [mysql-connector-java-8.0.16.jar](https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.16/mysql-connector-java-8.0.16.jar). 2. Create a new `Dockerfile` to add MySQL driver: ``` -FROM dolphinscheduler.docker.scarf.sh/apache/dolphinscheduler:<version> +FROM dolphinscheduler.docker.scarf.sh/apache/dolphinscheduler-<service>:<version> +# For example +# FROM dolphinscheduler.docker.scarf.sh/apache/dolphinscheduler-tools:<version> Review Comment: We should use two of the docker image we metion above ```suggestion # FROM dolphinscheduler.docker.scarf.sh/apache/dolphinscheduler-worker:<version> ``` ########## docs/docs/en/guide/installation/kubernetes.md: ########## @@ -229,24 +235,29 @@ externalDatabase: > Because of the commercial license, we cannot directly use the driver of > MySQL. > -> If you want to add MySQL datasource, you can build a new image based on the `apache/dolphinscheduler` image follow the following instructions: +> If you want to add MySQL datasource, you can build a new image based on the `apache/dolphinscheduler-<service>` image follow the following instructions: +> +> You needs to change the two images of dolphinscheduler-worker dolphinscheduler-api service. Review Comment: ```suggestion > You need to change the two service images including dolphinscheduler-worker, dolphinscheduler-api. ``` ########## docs/docs/en/guide/installation/kubernetes.md: ########## @@ -258,24 +269,29 @@ docker build -t apache/dolphinscheduler:mysql-driver . > Because of the commercial license, we cannot directly use the driver of > Oracle. > -> If you want to add Oracle datasource, you can build a new image based on the `apache/dolphinscheduler` image follow the following instructions: +> If you want to add Oracle datasource, you can build a new image based on the `apache/dolphinscheduler-<service>` image follow the following instructions: +> +> You needs to change the two images of dolphinscheduler-worker dolphinscheduler-api service. Review Comment: could we combine MySQL and Oracle into the same section? I find out the only different is jar name, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
