Tianqi-Dotes commented on code in PR #10217:
URL: https://github.com/apache/dolphinscheduler/pull/10217#discussion_r881088536
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -20,7 +20,7 @@ The Mlflow plugin currently supports and will support the
following:
- [ ] MLflow Models
- [x] MLFLOW: Use `MLflow models serve` to deploy a model service
- [x] Docker: Run the container after packaging the docker image
- - [ ] Docker Compose: Use docker compose to run the container, Will
replace the docker run above
+ - [x] Docker Compose: Use docker compose to run the container, Will
replace the docker run above
Review Comment:
Docker Compose: Use docker compose to run the container, Will replace the
docker run above
-》
Docker Compose: Use docker compose to run the container, it will replace the
docker run above
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -150,6 +150,16 @@ The actual interface is as follows
- **model-uri** ：Model-uri of mlflow , support `models:/<model_name>/suffix`
format and `runs:/` format. See
https://mlflow.org/docs/latest/tracking.html#artifact-stores
- **Port** ：The port to listen on
+#### DOCKER COMPOSE
+
+
+
+- **mlflow server tracking uri** ：MLflow server uri, default
http://localhost:5000.
Review Comment:
- **mlflow server tracking uri** ：MLflow server uri, default
http://localhost:5000.
- ->
- **MLflow Server Tracking URI**: MLflow server URI, default is
`http://localhost:5000`.
please replace and paste my corrections
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -20,7 +20,7 @@ The Mlflow plugin currently supports and will support the
following:
- [ ] MLflow Models
Review Comment:
please make corrections to all the `mlflow` to `MLflow`
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -150,6 +150,16 @@ The actual interface is as follows
- **model-uri** ：Model-uri of mlflow , support `models:/<model_name>/suffix`
format and `runs:/` format. See
https://mlflow.org/docs/latest/tracking.html#artifact-stores
- **Port** ：The port to listen on
+#### DOCKER COMPOSE
+
+
+
+- **mlflow server tracking uri** ：MLflow server uri, default
http://localhost:5000.
+- **model-uri** ：Model-uri of mlflow , support `models:/<model_name>/suffix`
format and `runs:/` format. See
https://mlflow.org/docs/latest/tracking.html#artifact-stores
Review Comment:
- **model-uri**
->
- **Model-uri** or
- **Model-URI**
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -150,6 +150,16 @@ The actual interface is as follows
- **model-uri** ：Model-uri of mlflow , support `models:/<model_name>/suffix`
format and `runs:/` format. See
https://mlflow.org/docs/latest/tracking.html#artifact-stores
- **Port** ：The port to listen on
+#### DOCKER COMPOSE
+
+
+
+- **mlflow server tracking uri** ：MLflow server uri, default
http://localhost:5000.
+- **model-uri** ：Model-uri of mlflow , support `models:/<model_name>/suffix`
format and `runs:/` format. See
https://mlflow.org/docs/latest/tracking.html#artifact-stores
+- **Port** ：The port to listen on
+- **max cpu limit** ：For example `1.0` or `0.5`, the same as docker compose.
Review Comment:
- **max cpu limit**
- ->
- **Max CPU Limit**
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -150,6 +150,16 @@ The actual interface is as follows
- **model-uri** ：Model-uri of mlflow , support `models:/<model_name>/suffix`
format and `runs:/` format. See
https://mlflow.org/docs/latest/tracking.html#artifact-stores
- **Port** ：The port to listen on
+#### DOCKER COMPOSE
+
+
+
+- **mlflow server tracking uri** ：MLflow server uri, default
http://localhost:5000.
+- **model-uri** ：Model-uri of mlflow , support `models:/<model_name>/suffix`
format and `runs:/` format. See
https://mlflow.org/docs/latest/tracking.html#artifact-stores
+- **Port** ：The port to listen on
+- **max cpu limit** ：For example `1.0` or `0.5`, the same as docker compose.
+- **max memory limit** ：For example `1G` or `500M`, the same as docker compose.
Review Comment:
- **max memory limit**
- >
- **Max Memory Limit**
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -150,6 +150,16 @@ The actual interface is as follows
- **model-uri** ：Model-uri of mlflow , support `models:/<model_name>/suffix`
format and `runs:/` format. See
https://mlflow.org/docs/latest/tracking.html#artifact-stores
- **Port** ：The port to listen on
+#### DOCKER COMPOSE
+
+
+
+- **mlflow server tracking uri** ：MLflow server uri, default
http://localhost:5000.
Review Comment:
please replace all the '：' to ':'
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -150,6 +150,16 @@ The actual interface is as follows
- **model-uri** ：Model-uri of mlflow , support `models:/<model_name>/suffix`
format and `runs:/` format. See
https://mlflow.org/docs/latest/tracking.html#artifact-stores
- **Port** ：The port to listen on
+#### DOCKER COMPOSE
+
+
+
Review Comment:
please add '.' at the end of the bullets here, or remove all the ',' here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
