[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #9924: [Fix#9923] The alarm instance management interface is always in the loading state

Wed, 25 May 2022 02:13:39 -0700 


SnowMoon-Dev commented on code in PR #9924:
URL: https://github.com/apache/dolphinscheduler/pull/9924#discussion_r881418858


##########
dolphinscheduler-ui/src/views/security/alarm-instance-manage/use-form.ts:
##########
@@ -72,11 +72,15 @@ export function useForm() {
   const getUiPluginsByType = async () => {
     if (state.pluginsLoading) return
     state.pluginsLoading = true
-    const plugins = await queryUiPluginsByType({ pluginType: 'ALERT' })
-    state.uiPlugins = plugins.map((plugin: IPlugin) => ({
-      label: plugin.pluginName,
-      value: plugin.id
-    }))
+    try {
+      const plugins = await queryUiPluginsByType({ pluginType: 'ALERT' })
+      state.uiPlugins = plugins.map((plugin: IPlugin) => ({
+        label: plugin.pluginName,
+        value: plugin.id
+      }))
+    } catch (e) {
+      state.pluginsLoading = false
+    }
     state.pluginsLoading = false

Review Comment:
   okļ¼Œthanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to