jieguangzhou commented on code in PR #10217:
URL: https://github.com/apache/dolphinscheduler/pull/10217#discussion_r883327164
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowTask.java:
##########
@@ -98,10 +98,15 @@ public void handle() throws Exception {
@Override
public void cancelApplication(boolean cancelApplication) throws Exception {
// cancel process
- shellCommandExecutor.cancelApplication();
+ if
(mlflowParameters.getDeployType().equals(MlflowConstants.MLFLOW_MODELS_DEPLOY_TYPE_DOCKER_COMPOSE))
{
+ String envCommand = mlflowParameters.getDockerComposeEnvCommand();
+ shellCommandExecutor.run(envCommand + "\n" +
MlflowConstants.DOCKER_COMPOSE_CANCEL);
Review Comment:
I think our scenario is just for releasing the model online, and the
subsequent operations are not the concern of this component. So, we should not
remove the container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
