zhongjiajie commented on code in PR #10170:
URL: https://github.com/apache/dolphinscheduler/pull/10170#discussion_r884396259
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -83,7 +83,7 @@ public class SqlTask extends AbstractTaskExecutor {
/**
* create function format
*/
- private static final String CREATE_FUNCTION_FORMAT = "create temporary
function {0} as ''{1}''";
+ private static final String CREATE_OR_REPLACE_FUNCTION_FORMAT = "create or
replace temporary function {0} as ''{1}''";
Review Comment:
I am ok with this patch, it is compatible with more cases without breaking
the before behavior, but could we add some comments before L86 to tell
developers why should we include `replace` in this syntax?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
