SbloodyS commented on code in PR #10294:
URL: https://github.com/apache/dolphinscheduler/pull/10294#discussion_r884912534
##########
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/HttpUtilsTest.java:
##########
@@ -40,10 +40,10 @@ public class HttpUtilsTest {
@Test
public void testGetTest() {
// success
- String result = HttpUtils.get("https://github.com/manifest.json";);
+ String result =
HttpUtils.get("https://www.baidu.com/sugrec?prod=pc_his&from=pc_web&json=1&sid=36427_36454_31253_36422_36165_36487_36055_36376_36234_26350_36469_36316&hisdata=&_t=1653904731156&req=2&csor=0";);
Review Comment:
I don't think this is a good idea. Due to the instability of Baidu. This url
may cause unstable in unit test.
And If GitHub cannot be accessed, the DS code can not be pulled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
