caishunfeng commented on code in PR #10301:
URL: https://github.com/apache/dolphinscheduler/pull/10301#discussion_r885168169
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AccessTokenService.java:
##########
@@ -55,7 +55,7 @@ public interface AccessTokenService {
* @param token token string (if it is absent, it will be automatically
generated)
* @return create result code
*/
- Map<String, Object> createToken(User loginUser, int userId, String
expireTime, String token);
+ Result createToken(User loginUser, int userId, String expireTime, String
token);
Review Comment:
```suggestion
CreateTokenResponse createToken(User loginUser, int userId, String
expireTime, String token);
```
I think use the specific response object is better, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
